dimas-b commented on code in PR #2527: URL: https://github.com/apache/polaris/pull/2527#discussion_r2376626808
########## persistence/nosql/async/api/src/main/java/org/apache/polaris/async/AsyncConfiguration.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.async; Review Comment: Suppose we had the package name `org.apache.polaris.nosql.async` and one week from now reuse it for handling events? Would that package name work in the events context? The code is already under the `nosql` directory name (as requested in other discussions). That provides isolation for current use cases. However, if it later becomes used in another context, it will be possible to relocate the module to another directory (for visibility / sharing) without affecting existing code with package renames. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
