dimas-b commented on code in PR #2527: URL: https://github.com/apache/polaris/pull/2527#discussion_r2382912852
########## persistence/nosql/async/api/src/main/java/org/apache/polaris/async/AsyncConfiguration.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.async; Review Comment: You bring good points / questions, @dennishuo . I think it's certainly possible to get a more thorough discussion about them... However, I wonder if it might be preferable to do that on the `dev` ML. From the practical point of view the Polaris codebase is still in rapid development are we're adding a lot of code in other areas too. Polishing everything to perfection is probably going to slow down progress to crawl :sweat_smile: So, to allow the bigger NoSQL feature work to progress, would you be ok with renaming the package to something NoSQL-specific for now so that prospective users are less likely to assume it is "trivial" to use in other contexts? My suggestion: `org.apache.polaris.nodes.async` (since it is currently used only within the node management code in #1189). I think adding some more javadoc in this PR would be reasonable, but I'm not sure adding exhaustive javadoc would be practical. @dennishuo @flyrain WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
