adnanhemani commented on code in PR #2602: URL: https://github.com/apache/polaris/pull/2602#discussion_r2377854010
########## runtime/service/src/main/java/org/apache/polaris/service/tracing/RequestIdFilter.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.tracing; + +import jakarta.annotation.Priority; +import jakarta.enterprise.context.ApplicationScoped; +import jakarta.inject.Inject; +import jakarta.ws.rs.container.ContainerRequestContext; +import jakarta.ws.rs.container.ContainerRequestFilter; +import jakarta.ws.rs.container.PreMatching; +import jakarta.ws.rs.ext.Provider; +import java.util.UUID; +import org.apache.polaris.service.config.FilterPriorities; +import org.apache.polaris.service.logging.LoggingConfiguration; + +@PreMatching +@ApplicationScoped +@Priority(FilterPriorities.REQUEST_ID_FILTER) +@Provider +public class RequestIdFilter implements ContainerRequestFilter { + + public static final String REQUEST_ID_KEY = "requestId"; + + @Inject LoggingConfiguration loggingConfiguration; + + @Override + public void filter(ContainerRequestContext rc) { + var requestId = rc.getHeaderString(loggingConfiguration.requestIdHeaderName()); + if (requestId == null) { + requestId = UUID.randomUUID().toString(); Review Comment: I've added the `RequestIdGenerator`, which is a very, very simple ID generator - since we don't require the level of complexity that has been made in the SnowflakeIdGenerator. It's just a quick implementation of @dimas-b's suggestion above: > If the request ID does not have to be a UUID (I'm a bit out-of-date on this) it may be worth using a per-node (or per-thread) UUID (allocated one per restart) plus a simple counter. I'm very hesitant to introduce a complete dependency on the NoSql Persistence for the Service module and so creating the `RequestIdGenerator` is my minor effort to avoid doing that. I'm sure there may be a better reason for introducing this dependency in the future, but I don't want to sidetrack the simple goal (and simple requirements) of this PR with whether we should introduce this dependency or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
