adutra commented on code in PR #2602: URL: https://github.com/apache/polaris/pull/2602#discussion_r2379425893
########## runtime/service/src/main/java/org/apache/polaris/service/tracing/RequestIdFilter.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.tracing; + +import jakarta.annotation.Priority; +import jakarta.enterprise.context.ApplicationScoped; +import jakarta.inject.Inject; +import jakarta.ws.rs.container.ContainerRequestContext; +import jakarta.ws.rs.container.ContainerRequestFilter; +import jakarta.ws.rs.container.PreMatching; +import jakarta.ws.rs.ext.Provider; +import java.util.UUID; +import org.apache.polaris.service.config.FilterPriorities; +import org.apache.polaris.service.logging.LoggingConfiguration; + +@PreMatching +@ApplicationScoped +@Priority(FilterPriorities.REQUEST_ID_FILTER) +@Provider +public class RequestIdFilter implements ContainerRequestFilter { + + public static final String REQUEST_ID_KEY = "requestId"; + + @Inject LoggingConfiguration loggingConfiguration; + + @Override + public void filter(ContainerRequestContext rc) { + var requestId = rc.getHeaderString(loggingConfiguration.requestIdHeaderName()); + if (requestId == null) { + requestId = UUID.randomUUID().toString(); Review Comment: > are we sure that UUID.randomUUID() is blocking call and in what chance will it exhaust the system entropy? I've never got a satisfying answer for that question 😄 Most commenters stress the fact that `dev/urandom` never blocks. This is certainly true, but doesn't address the fact that the entropy pool might get exhausted at some point, in which case your UUIDs will have very poor randomness. Furthermore, the `UUID.randomUUID()` call is explicitly considered blocking by BlockHound: https://github.com/reactor/BlockHound/issues/157 I _think_ that this is due to the fact that `new SecureRandom()` does some magic to select the random numbers provider, and even if the default provider doesn't block (it plugs into `/dev/urandom`), you still can configure your JVM with a different provider that could block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
