dennishuo commented on code in PR #2508:
URL: https://github.com/apache/polaris/pull/2508#discussion_r2408756158
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -416,6 +419,38 @@ ResolvedEntityResult loadResolvedEntityByName(
@Nonnull PolarisEntityType entityType,
@Nonnull String entityName);
+ /**
+ * Load a batch of resolved entities given their {@link
EntityNameLookupRecord}. Will return an
+ * empty list if the input list is empty. Order in that returned list is the
same as the input
+ * list. Some elements might be NULL if the entity has been dropped.
+ *
+ * @param callCtx call context
+ * @param entityLookupRecords the list of entity lookup records to load
+ * @return a non-null list of entities corresponding to the lookup keys.
Some elements might be
+ * NULL if the entity has been dropped.
+ */
+ @Nonnull
+ ResolvedEntitiesResult loadResolvedEntities(
Review Comment:
Yeah sounds good, I think it's good to have the more opinionated "all
entities in the batch are the same EntityType" method signature for now, as
it's easier to ensure different impls can fulfill the interface. Signature
`(EntityType, List<EntityId>)` looks good to me, and let's remove the
overloaded method regarding `EntityNameLookupRecord`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
