dimas-b commented on code in PR #2508:
URL: https://github.com/apache/polaris/pull/2508#discussion_r2417983899
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -416,6 +418,23 @@ ResolvedEntityResult loadResolvedEntityByName(
@Nonnull PolarisEntityType entityType,
@Nonnull String entityName);
+ /**
+ * Load a batch of resolved entities of a specified entity type given their
{@link
+ * PolarisEntityId}. Will return an empty list if the input list is empty.
Order in that returned
+ * list is the same as the input list. Some elements might be NULL if the
entity has been dropped.
+ *
+ * @param callCtx call context
+ * @param entityType the type of entities to load
+ * @param entityIds the list of entity ids to load
+ * @return a non-null list of entities corresponding to the lookup keys.
Some elements might be
+ * NULL if the entity has been dropped.
+ */
+ @Nonnull
+ ResolvedEntitiesResult loadResolvedEntities(
Review Comment:
The name LGTM, but I guess it does not match the PR description anymore 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
