flyrain opened a new pull request, #2863:
URL: https://github.com/apache/polaris/pull/2863

   The trailing comma makes the `parameter` a tuple, rather than a dict.
   ```
   > cd client/python
   > ../../polaris-venv/bin/python -m pytest 
test/test_cli_parsing.py::TestCliParsing::test_policies_attach_parameters_parsed_to_dict
 -q
   
       def test_policies_attach_parameters_parsed_to_dict(self):
           options = Parser.parse([
               'policies', 'attach', 'policy-name',
               '--catalog', 'cat',
               '--attachment-type', 'catalog',
               '--parameters', 'key=value',
           ])
           command = Command.from_options(options)
   >       self.assertIsInstance(command.parameters, dict)
   E       AssertionError: ({'key': 'value'},) is not an instance of <class 
'dict'>
   
   test/test_cli_parsing.py:629: AssertionError
   
   FAILED 
test/test_cli_parsing.py::TestCliParsing::test_policies_attach_parameters_parsed_to_dict
 - AssertionError: ({'key': 'value'},) is not an instance of <class 'dict'>
   1 failed in 0.47s
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to