HonahX commented on code in PR #2863:
URL: https://github.com/apache/polaris/pull/2863#discussion_r2453437539
##########
client/python/cli/command/__init__.py:
##########
@@ -40,7 +40,7 @@ def options_get(key, f=lambda x: x):
set_properties =
Parser.parse_properties(options_get(Arguments.SET_PROPERTY))
remove_properties = options_get(Arguments.REMOVE_PROPERTY)
catalog_client_scopes = options_get(Arguments.CATALOG_CLIENT_SCOPE)
- parameters =
Parser.parse_properties(options_get(Arguments.PARAMETERS)),
+ parameters = Parser.parse_properties(options_get(Arguments.PARAMETERS))
Review Comment:
I am surprised that this is not caught by existing test and regtest. Thanks
for adding the test!
##########
client/python/cli/command/__init__.py:
##########
@@ -40,7 +40,7 @@ def options_get(key, f=lambda x: x):
set_properties =
Parser.parse_properties(options_get(Arguments.SET_PROPERTY))
remove_properties = options_get(Arguments.REMOVE_PROPERTY)
catalog_client_scopes = options_get(Arguments.CATALOG_CLIENT_SCOPE)
- parameters =
Parser.parse_properties(options_get(Arguments.PARAMETERS)),
+ parameters = Parser.parse_properties(options_get(Arguments.PARAMETERS))
Review Comment:
I am surprised that this is not caught by existing test and regtest. Thanks
for adding the test and fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
