cccs-cat001 commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2460697122
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/MetricsReporter.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.polaris.service.reporting;
+
+import org.apache.iceberg.rest.requests.ReportMetricsRequest;
+
+public interface MetricsReporter {
Review Comment:
So that was my original plan! But the iceberg `MetricsReporter` is intended
for client-side operations, so implementing it won't suffice for the `/metrics`
endpoint reporting.
It would be ideal to change the name of it so that it doesn't get confused,
but I wasn't sure of a better name 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
