cccs-cat001 commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2461654615
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/MetricsReporter.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.polaris.service.reporting;
+
+import org.apache.iceberg.rest.requests.ReportMetricsRequest;
+
+public interface MetricsReporter {
Review Comment:
the iceberg implementation is definitely not what we want to
extend/implement here -
https://iceberg.apache.org/docs/1.10.0/docs/metrics-reporting
it's a client side thing. but I can change the name of this interface to
PolarisMetricsReporter to have that separation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
