cccs-cat001 commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2465341084
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/LoggingMetricsReporter.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.polaris.service.reporting;
+
+import io.smallrye.common.annotation.Identifier;
+import jakarta.enterprise.context.RequestScoped;
+import org.apache.iceberg.rest.requests.ReportMetricsRequest;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@RequestScoped
+@Identifier("logging")
+public class LoggingMetricsReporter implements MetricsReporter {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(LoggingMetricsReporter.class);
+
+ @Override
+ public void reportMetric(
Review Comment:
okay this is fine. I just made 2 implementations to ensure that I was going
down the right path anyways :P
I've dropped down to one implementation with the configurable logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
