adutra commented on code in PR #2941:
URL: https://github.com/apache/polaris/pull/2941#discussion_r2480976039
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -52,6 +52,14 @@ quarkus.http.cors.exposed-headers=*
quarkus.http.cors.access-control-max-age=PT10M
quarkus.http.cors.access-control-allow-credentials=true
+# --- Polaris Server header (Quarkus-managed) ---
+# Keep .value present (required by Quarkus), but make the path never match so
it's effectively OFF by default.
+quarkus.http.header."Server".value=Polaris/${quarkus.application.version}
Review Comment:
Do we need to put anything in this file? The property is not marked as a
build-time property in the [configuration
reference](https://quarkus.io/guides/all-config#quarkus-vertx-http_quarkus-http-header-header-value).
I think users could just add this setting in their own configuration. There
should be no need to rebuild Polaris, just add it in one of the [supported
configuration
sources](https://quarkus.io/guides/config-reference#configuration-sources).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
