snazy commented on code in PR #2941:
URL: https://github.com/apache/polaris/pull/2941#discussion_r2485778957
##########
site/content/in-dev/unreleased/configuring-polaris-for-production.md:
##########
@@ -125,6 +125,19 @@ polaris.realm-context.require-header=true
This will cause Polaris to also return a `404 Not Found` response if the realm
header is not present
in the request.
+### Polaris Server Header
+
+Polaris can emit an informational `Server` HTTP response header using Quarkus'
built-in header
+configuration. Add the following property to one of the supported
configuration sources (for example,
+`application.properties`) to enable it with the Polaris version string:
+
+```properties
+quarkus.http.header."Server".value=Polaris/${quarkus.application.version}
+```
+
+If you prefer to scope the header to specific environments, only set the
property for the desired
+profile (for example, `%prod`).
Review Comment:
```suggestion
```
I could imagine that "specific environment" is confusing for non-Quarkus
affine users.
##########
site/content/in-dev/unreleased/configuring-polaris-for-production.md:
##########
@@ -125,6 +125,19 @@ polaris.realm-context.require-header=true
This will cause Polaris to also return a `404 Not Found` response if the realm
header is not present
in the request.
+### Polaris Server Header
Review Comment:
Hm, I think it's better to move this section down to the end of the doc.
It's (at least IMHO) an advanced option for very specific use cases, while
the other items mentioned here are all mandatory settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
