adutra commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2485774436
##########
runtime/service/src/main/java/org/apache/polaris/service/config/ServiceProducers.java:
##########
@@ -405,4 +407,11 @@ public PolarisCredentialManager polarisCredentialManager(
public void closeTaskExecutor(@Disposes @Identifier("task-executor")
ManagedExecutor executor) {
executor.close();
}
+
+ @Produces
+ @RequestScoped
+ public MetricsReporter metricsReporter(
+ MetricsReportingConfiguration config, @Any Instance<MetricsReporter>
reporters) {
+ return reporters.select(Identifier.Literal.of(config.type())).get();
Review Comment:
I'm -1 on the factory approach, The factory approach in Polaris is generally
used for creating _and caching_ realm-scoped beans. The producer method
approach OTOH is used for selecting beans at runtime according to their
`@Identifier`.
Here, it's clearly an application-scoped bean, selectable at runtime with
its `@Identifier`.
The correct fix for me is just to replace `@RequestScoped` with
`@ApplicationScoped` in the producer method:
```java
@ApplicationScoped
public MetricsReporter metricsReporter(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
