pingtimeout commented on code in PR #2887: URL: https://github.com/apache/polaris/pull/2887#discussion_r2485949045
########## runtime/service/src/main/java/org/apache/polaris/service/reporting/DefaultMetricsReporter.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.reporting; + +import com.google.common.annotations.VisibleForTesting; +import io.smallrye.common.annotation.Identifier; +import jakarta.enterprise.context.RequestScoped; +import org.apache.commons.lang3.function.TriConsumer; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.metrics.MetricsReport; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@RequestScoped +@Identifier("default") Review Comment: > I am the one that suggested that we could combine both together, since the logger level could be OFF by default. I still don't see why we would have 2, but fair enough. I am ok with a single bean, that was just a link to Robert's other comment. > We already have a dozen CDI beans named default. Why is this one problematic? I was not aware of that :-). I don't this this one is _more_ problematic than any other. This is just an attempt at having clearer names. Feel free to consider this as a nit. If this name is consistent with the rest of the codebase, I guess `default` is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
