adutra commented on code in PR #2939: URL: https://github.com/apache/polaris/pull/2939#discussion_r2485797926
########## helm/polaris/README.md: ########## @@ -60,10 +62,24 @@ eval $(minikube docker-env) -Dquarkus.container-image.build=true ``` +Otherwise load ready images from Docker Hub: +```bash +minikube image pull apache/polaris:latest +minikube image pull apache/polaris-admin-tool:latest +``` Review Comment: This isn't for Helm, but for the kubelet inside Minikube. The kubelet can only download images if they are publicly available. If the image is from a private registry, or only present locally in the host machine (e.g. because you built a custom `apache/polaris:latest` image from sources and you want to use it), then this instruction is necessary. All in all, I think it's fine to leave the instructions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
