flyrain commented on code in PR #2939: URL: https://github.com/apache/polaris/pull/2939#discussion_r2488953526
########## helm/polaris/README.md: ########## @@ -60,10 +62,24 @@ eval $(minikube docker-env) -Dquarkus.container-image.build=true ``` +Otherwise load ready images from Docker Hub: +```bash +minikube image pull apache/polaris:latest +minikube image pull apache/polaris-admin-tool:latest +``` Review Comment: Thanks for the clarification, that makes sense. Good point about the kubelet behavior inside Minikube. I agree it’s fine to keep the `minikube image pull` instructions for users running with private or locally built images. That said, I still think it’d be clearer to separate the doc into two sections, one for the standard “Helm install from the official repo” path, and another “advanced / from source” section for developers. This way, most users can follow the simple flow without extra steps, while contributors still have the detailed Minikube setup if needed. More details are in this comment, https://github.com/apache/polaris/pull/2939#pullrequestreview-3409217448. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
