snazy commented on code in PR #2976: URL: https://github.com/apache/polaris/pull/2976#discussion_r2491848697
########## getting-started/quickstart/README.md: ########## @@ -0,0 +1,29 @@ +# Apache Polaris Quickstart with File-Based Backend Review Comment: License header is missing ########## getting-started/quickstart/README.md: ########## @@ -0,0 +1,29 @@ +# Apache Polaris Quickstart with File-Based Backend + Review Comment: Wonder whether you should just link to the markdown in `site/` to de-duplicate content. WDYT? ########## getting-started/quickstart/docker-compose.yml: ########## @@ -0,0 +1,225 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +services: + + # Helper service to fix permissions on the data volume + polaris-init: + image: apache/polaris:latest + user: "0:0" + volumes: + - polaris-data:/var/polaris/data + command: > + sh -c "mkdir -p /var/polaris/data && chown -R 10000:10001 /var/polaris/data && echo 'Permissions fixed'" + + polaris: + image: apache/polaris:latest + depends_on: + polaris-init: + condition: service_completed_successfully + ports: + # API port + - "8181:8181" + # Management port (metrics and health checks) + - "8182:8182" + environment: + # Bootstrap credentials: realm,client_id,client_secret + POLARIS_BOOTSTRAP_CREDENTIALS: POLARIS,${ROOT_CLIENT_ID:-root},${ROOT_CLIENT_SECRET:-s3cr3t} + # Realm configuration + POLARIS_REALM_CONTEXT_REALMS: ${POLARIS_REALM:-POLARIS} + # Disable OpenTelemetry for simplicity + QUARKUS_OTEL_SDK_DISABLED: "true" + # Enable file-based storage (insecure, for development only) + polaris.features."ALLOW_INSECURE_STORAGE_TYPES": "true" + polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\"]" Review Comment: I'm torn on this one. Humans are lazy, and I fear that people blindly copy this. Mean, we cannot prevent them from doing this, but 🤷 Would it be hard to add an S3 backend as @dimas-b described for Apache Ozone? Or could we even join both pages into a single and simple getting started page? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
