adam-christian-software commented on code in PR #2976: URL: https://github.com/apache/polaris/pull/2976#discussion_r2491950703
########## getting-started/quickstart/docker-compose.yml: ########## @@ -0,0 +1,225 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +services: + + # Helper service to fix permissions on the data volume + polaris-init: + image: apache/polaris:latest + user: "0:0" + volumes: + - polaris-data:/var/polaris/data + command: > + sh -c "mkdir -p /var/polaris/data && chown -R 10000:10001 /var/polaris/data && echo 'Permissions fixed'" + + polaris: + image: apache/polaris:latest + depends_on: + polaris-init: + condition: service_completed_successfully + ports: + # API port + - "8181:8181" + # Management port (metrics and health checks) + - "8182:8182" + environment: + # Bootstrap credentials: realm,client_id,client_secret + POLARIS_BOOTSTRAP_CREDENTIALS: POLARIS,${ROOT_CLIENT_ID:-root},${ROOT_CLIENT_SECRET:-s3cr3t} + # Realm configuration + POLARIS_REALM_CONTEXT_REALMS: ${POLARIS_REALM:-POLARIS} + # Disable OpenTelemetry for simplicity + QUARKUS_OTEL_SDK_DISABLED: "true" + # Enable file-based storage (insecure, for development only) + polaris.features."ALLOW_INSECURE_STORAGE_TYPES": "true" + polaris.features."SUPPORTED_CATALOG_STORAGE_TYPES": "[\"FILE\"]" Review Comment: I'm torn as well. 1. I agree that, by using the FILE storage type, we are encouraging others to use it. I chose it because it was a one-line, no configuration execution. 2. Let me read down the ozone docker-compose and get back to you. I would assume that it could provide an easy way for us to not have to rely on FILE. 3. If Ozone does allow us to have the one-click configuration, I'll split the ozone getting-started from the quick start because quickstart does a bunch of stuff like grants, creating catalogs, & having pretty messages for users to do the next thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
