adutra commented on code in PR #2998:
URL: https://github.com/apache/polaris/pull/2998#discussion_r2514596203
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisCatalogsEventServiceDelegator.java:
##########
@@ -51,37 +53,50 @@ public class PolarisCatalogsEventServiceDelegator
implements PolarisCatalogsApiS
@Inject @Delegate PolarisCatalogsApiService delegate;
@Inject PolarisEventListener polarisEventListener;
+ @Inject PolarisEventMetadataFactory eventMetadataFactory;
@Override
public Response createCatalog(
CreateCatalogRequest request, RealmContext realmContext, SecurityContext
securityContext) {
polarisEventListener.onBeforeCreateCatalog(
- new
CatalogsServiceEvents.BeforeCreateCatalogEvent(request.getCatalog().getName()));
+ new CatalogsServiceEvents.BeforeCreateCatalogEvent(
+ PolarisEvent.createEventId(),
Review Comment:
I thought about that too, but after some hesitation, I think an ID is a bit
more than "metadata". The fact that this specific field must be unique makes it
imho a bit special. Wdyt?
That said I don't have strong opinions on this, and I'd be OK to move it to
metadata if there is a consensus to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
