adnanhemani commented on code in PR #2998:
URL: https://github.com/apache/polaris/pull/2998#discussion_r2543599598
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisCatalogsEventServiceDelegator.java:
##########
@@ -51,37 +53,50 @@ public class PolarisCatalogsEventServiceDelegator
implements PolarisCatalogsApiS
@Inject @Delegate PolarisCatalogsApiService delegate;
@Inject PolarisEventListener polarisEventListener;
+ @Inject PolarisEventMetadataFactory eventMetadataFactory;
@Override
public Response createCatalog(
CreateCatalogRequest request, RealmContext realmContext, SecurityContext
securityContext) {
polarisEventListener.onBeforeCreateCatalog(
- new
CatalogsServiceEvents.BeforeCreateCatalogEvent(request.getCatalog().getName()));
+ new CatalogsServiceEvents.BeforeCreateCatalogEvent(
+ PolarisEvent.createEventId(),
Review Comment:
I'd say it would be named `eventId()` in this model. IMO, the rest of the
fields in `PolarisEventMetadata` are also vital parts of the event's identity -
but I understand the argument philosophically. It's ultimately your call, but I
still don't see the harm of doing this versus the benefits are the conciseness
of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
