tokoko commented on code in PR #3224:
URL: https://github.com/apache/polaris/pull/3224#discussion_r2594584706
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -123,6 +125,7 @@ public StorageAccessConfig getOrGenerateSubScopeCreds(
allowListOperation,
allowedReadLocations,
allowedWriteLocations,
+ polarisPrincipal,
Review Comment:
If the feature flag is application-level, then we could check it while
constructing a cache key, but not really a fan of that option.
> storage integrations implementation should provide a converter method,
yeah, this would be a big refactor. currently cache lookup is done become
storage integration is loaded, we'd have to switch the order first. Also they
are too far apart from one another. The simpler solution might be to delegate
cache key generation to integrations themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
