dimas-b commented on code in PR #3224:
URL: https://github.com/apache/polaris/pull/3224#discussion_r2594623699
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -123,6 +125,7 @@ public StorageAccessConfig getOrGenerateSubScopeCreds(
allowListOperation,
allowedReadLocations,
allowedWriteLocations,
+ polarisPrincipal,
Review Comment:
We could use two flags: 1) whether to propagate the principal at all 2)
whether to use the principal name in STS calls.
The first flag would be useful for avoiding excessive cache key
proliferation. The second one - as I commented in another thread.
The first flag does add code complexity, but it could be an interim solution
until the cache can be handled more holistically. I believe it is important to
preserve cache efficiency in deployments that do not need to pass principals to
storage.
... but of course, if you have an alternative solution, please share
:slightly_smiling_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
