obelix74 commented on code in PR #3327:
URL: https://github.com/apache/polaris/pull/3327#discussion_r2652090377
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCache.java:
##########
@@ -130,21 +146,26 @@ public StorageAccessConfig getOrGenerateSubScopeCreds(
allowedReadLocations,
allowedWriteLocations,
refreshCredentialsEndpoint,
- includePrincipalNameInSubscopedCredential
- ? Optional.of(polarisPrincipal)
- : Optional.empty());
- LOGGER.atDebug().addKeyValue("key", key).log("subscopedCredsCache");
+ includePrincipalInCacheKey ? Optional.of(polarisPrincipal) :
Optional.empty(),
+ includeSessionTags ? Optional.of(credentialVendingContext) :
Optional.empty());
Function<StorageCredentialCacheKey, StorageCredentialCacheEntry> loader =
k -> {
LOGGER.atDebug().log("StorageCredentialCache::load");
+ // Use credentialVendingContext from the cache key for correctness.
+ // When session tags are disabled, the key stores Optional.empty(),
and we should
+ // use an empty context to ensure consistent behavior regardless of
what the
+ // local variable contains.
+ CredentialVendingContext contextFromKey =
+
k.credentialVendingContext().orElse(CredentialVendingContext.empty());
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
