dimas-b commented on code in PR #3327:
URL: https://github.com/apache/polaris/pull/3327#discussion_r2653367987
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/cache/StorageCredentialCacheKey.java:
##########
@@ -55,14 +56,47 @@ public interface StorageCredentialCacheKey {
@Value.Parameter(order = 8)
Optional<String> principalName();
+ /**
+ * The credential vending context for session tags. When session tags are
enabled, this contains
+ * the catalog, namespace, table, and roles information. When session tags
are disabled, this
+ * should be {@link CredentialVendingContext#empty()} to ensure consistent
cache key behavior.
+ */
+ @Value.Parameter(order = 9)
+ CredentialVendingContext credentialVendingContext();
+
+ /**
+ * Returns a sanitized string representation of this cache key suitable for
logging. This excludes
+ * potentially sensitive information like catalog names, namespaces, table
names, and request IDs
+ * that may be present in the credential vending context.
+ *
+ * @return a sanitized string representation for logging
+ */
+ default String toSanitizedLogString() {
Review Comment:
This method not used anymore... Would you mind removing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
