dimas-b commented on code in PR #3327:
URL: https://github.com/apache/polaris/pull/3327#discussion_r2655537621
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsCredentialsStorageIntegration.java:
##########
@@ -118,6 +124,19 @@ public StorageAccessConfig getSubscopedCreds(
accountId)
.toJson())
.durationSeconds(storageCredentialDurationSeconds);
+
+ // Add session tags when the feature is enabled
+ if (includeSessionTags) {
+ List<Tag> sessionTags =
+ buildSessionTags(polarisPrincipal.getName(),
credentialVendingContext);
Review Comment:
Sorry, but I do not think the new code is correct. I added a specific
comment here: https://github.com/apache/polaris/pull/3327#discussion_r2655536056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
