dimas-b commented on code in PR #3380:
URL: https://github.com/apache/polaris/pull/3380#discussion_r2673118661
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java:
##########
@@ -52,19 +52,32 @@ public Response createGenericTable(
CreateGenericTableRequest createGenericTableRequest,
RealmContext realmContext,
SecurityContext securityContext) {
+
Review Comment:
nit: these whitespace change appear to be irrelevant to the purpose of the
PR. Since the PR does not attempt to refactor code, why introduce whitespace
changes? IMHO, they complicate review.
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/generic/CatalogGenericTableEventServiceDelegator.java:
##########
@@ -52,19 +52,32 @@ public Response createGenericTable(
CreateGenericTableRequest createGenericTableRequest,
RealmContext realmContext,
SecurityContext securityContext) {
+
String catalogName = prefixParser.prefixToCatalogName(realmContext,
prefix);
+
polarisEventListener.onBeforeCreateGenericTable(
new CatalogGenericTableServiceEvents.BeforeCreateGenericTableEvent(
eventMetadataFactory.create(), catalogName, namespace,
createGenericTableRequest));
+
Response resp =
delegate.createGenericTable(
prefix, namespace, createGenericTableRequest, realmContext,
securityContext);
+
+ LoadGenericTableResponse responseEntity = (LoadGenericTableResponse)
resp.getEntity();
Review Comment:
same here: why extract a variable when the PR's intention is to "document" ?
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
