rishii-19-works commented on code in PR #3380:
URL: https://github.com/apache/polaris/pull/3380#discussion_r2674177954
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -47,9 +47,11 @@ public static ImmutableAwsStorageConfigurationInfo.Builder
builder() {
// Technically, it should be
^arn:(aws|aws-cn|aws-us-gov):iam::(\d{12}):role/.+$, but we've
// generalized it to support non-aws S3 implementations
- @JsonIgnore public static final String ROLE_ARN_PATTERN =
"^.+:(.*):iam:.*:(.*):role/.+$";
+ @JsonIgnore
+ public static final String ROLE_ARN_PATTERN =
"^.+:(.*):iam:.*:(.*):role/.+$";
Review Comment:
Thanks for the review. I understand the concern about the irrelevant changes.
I’ll clean up the PR to keep it strictly scoped to the intended change and
remove any unrelated modifications. I’ll update the PR shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
