dimas-b commented on code in PR #3409:
URL: https://github.com/apache/polaris/pull/3409#discussion_r2677874569
##########
runtime/service/src/main/java/org/apache/polaris/service/storage/StorageConfiguration.java:
##########
@@ -97,6 +113,18 @@ default AwsCredentialsProvider stsCredentials() {
}
}
+ default AwsCredentialsProvider stsCredentials(String storageName) {
+ if (storageName != null && storages().containsKey(storageName)) {
+ StorageConfig storageConfig = storages().get(storageName);
+ if (storageConfig.awsAccessKey().isPresent() &&
storageConfig.awsSecretKey().isPresent()) {
Review Comment:
`storageConfig.isPresent()`?
##########
runtime/service/src/main/java/org/apache/polaris/service/storage/StorageConfiguration.java:
##########
@@ -97,6 +113,18 @@ default AwsCredentialsProvider stsCredentials() {
}
}
+ default AwsCredentialsProvider stsCredentials(String storageName) {
+ if (storageName != null && storages().containsKey(storageName)) {
+ StorageConfig storageConfig = storages().get(storageName);
+ if (storageConfig.awsAccessKey().isPresent() &&
storageConfig.awsSecretKey().isPresent()) {
Review Comment:
nit: `storageConfig.isPresent()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
