RussellSpitzer commented on PR #3396: URL: https://github.com/apache/polaris/pull/3396#issuecomment-3740148019
> I don’t think this PR is moving in the right direction. NoSQL is one of the persistence impl., but this change introduces NoSQL specific concerns into the business logic module. This blurs the separation of concerns and makes the business layer dependent on a concrete persistence backend, which will make the architecture harder to evolve and maintain. cc @dennishuo @collado-mike @singhpk234 @RussellSpitzer @flyrain Could you be more explicit in your concern here? I see the new config in the Application.conf which seems reasonable to me, and the test integration which also seems reasonable. This mirrors what we are doing with JDBC correct? Is there something else you are worried about? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
