dimas-b commented on code in PR #3396: URL: https://github.com/apache/polaris/pull/3396#discussion_r2683635976
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -41,6 +41,9 @@ quarkus.micrometer.enabled=true quarkus.micrometer.export.prometheus.enabled=true quarkus.oidc.enabled=true quarkus.otel.enabled=true +quarkus.mongodb.metrics.enabled=true Review Comment: Thinking some more about this: `runtime/defaults` is basically for the default Server image (or tar). However, users still need to make decisions about monitoring and backend database parameters. So it does make sense to comment out anything that is not "activated" by default. Helm charts can enable extra config at deployment time (e.g. if MongoDB is selected). Users of tar distributions should still set up extra infra for monitoring, so it's not really seamless even if it's enabled by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
