adutra commented on code in PR #3414:
URL: https://github.com/apache/polaris/pull/3414#discussion_r2687484984
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -104,6 +104,20 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
INCLUDE_TRACE_ID_IN_SESSION_TAGS =
+ PolarisConfiguration.<Boolean>builder()
+ .key("INCLUDE_TRACE_ID_IN_SESSION_TAGS")
Review Comment:
If you are able to compute things like the principal or the otel context,
it's because there is an active request context when the tags are computed. So,
I'm a bit surprised that it's not possible to get the request ID as well. Have
you tried this approach:
https://github.com/apache/polaris/blob/64b13a9915274a04e82a12c9fdcd095d12797ca0/runtime/service/src/main/java/org/apache/polaris/service/events/PolarisEventMetadataFactory.java#L111-L120
I'm not saying we absolutely must include the request id here, but I do
remember that for events, not including the request ID was a friction point for
some contributors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
