obelix74 commented on code in PR #3414:
URL: https://github.com/apache/polaris/pull/3414#discussion_r2687866748
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -104,6 +104,20 @@ public static void enforceFeatureEnabledOrThrow(
.defaultValue(false)
.buildFeatureConfiguration();
+ public static final FeatureConfiguration<Boolean>
INCLUDE_TRACE_ID_IN_SESSION_TAGS =
+ PolarisConfiguration.<Boolean>builder()
+ .key("INCLUDE_TRACE_ID_IN_SESSION_TAGS")
Review Comment:
I have pushed a commit adding support for `request_id`, but my understanding
is that the code that fetches the `request_id` will only work for `HTTP`
requests - this was the primary reason we removed `request_id` from the
previous PR that added `request_id`.
I request @dimas-b @adutra and @singhpk234 to review this and let me know if
we should keep this as part of this PR or remove it.
The `request_id` code follows the same design suggested by @dimas-b for the
`trace_id`. There is one change. Since the `request_id` is controlled by the
end-user and may contain non-STS friendly characters, I added code to sanitize
it - if this doesn't happen, vended credentials may fail to be issued.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
