MonkeyCanCode commented on code in PR #3496:
URL: https://github.com/apache/polaris/pull/3496#discussion_r2711116520
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -124,6 +124,13 @@ public URI getStsEndpointUri() {
return getStsEndpoint() == null ? getInternalEndpointUri() :
URI.create(getStsEndpoint());
}
+ @JsonIgnore
+ public boolean isAwsS3() {
+ String endpoint = getEndpoint();
+ // AWS S3 if no endpoint is specified or if it uses an amazonaws.com
endpoint
+ return endpoint == null || endpoint.contains(".amazonaws.com");
+ }
+
@JsonIgnore
Review Comment:
Yeah, refactor this maybe wise. Base on what I recalled, S3-compatible was
added later on and it was added on top of the AWS one. Thus current state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
