evindj commented on code in PR #3496:
URL: https://github.com/apache/polaris/pull/3496#discussion_r2711153160
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/aws/AwsStorageConfigurationInfo.java:
##########
@@ -124,6 +124,13 @@ public URI getStsEndpointUri() {
return getStsEndpoint() == null ? getInternalEndpointUri() :
URI.create(getStsEndpoint());
}
+ @JsonIgnore
+ public boolean isAwsS3() {
+ String endpoint = getEndpoint();
+ // AWS S3 if no endpoint is specified or if it uses an amazonaws.com
endpoint
+ return endpoint == null || endpoint.contains(".amazonaws.com");
Review Comment:
although this is generally fair, and will work for most of the cases, I was
thinking if it would make sense to enable KMS addition as a configuration
rather than something that is tightly coupled with whether or not it the
underlying storage is AWS. Not a blocker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
