dimas-b commented on code in PR #3396:
URL: https://github.com/apache/polaris/pull/3396#discussion_r2727978172
##########
runtime/defaults/src/main/resources/application.properties:
##########
@@ -283,6 +297,8 @@ quarkus.arc.ignored-split-packages=\
## Quarkus required setting for third party indexing
# fixed at build-time
+quarkus.index-dependency.agrona.group-id=org.agrona
+quarkus.index-dependency.agrona.artifact-id=agrona
Review Comment:
I did not local debugging and this indexing property does appear to be
advised by Quarkus for the `runtime/server` build.
Here's the warning message from Quarkus when running _without_ this property:
```
Unable to properly register the hierarchy of the following classes for
reflection as they are not in the Jandex index:
- org.agrona.collections.Int2ObjectHashMap (source: JacksonProcessor
annotated with @com.fasterxml.jackson.databind.annotation.JsonDeserialize >
org.apache.polaris.persistence.nosql.authz.api.ImmutableAclEntry$Json >
org.apache.polaris.persistence.nosql.authz.api.PrivilegeSet >
org.apache.polaris.persistence.nosql.authz.api.Privileges >
org.agrona.collections.Int2ObjectHashMap)
- org.agrona.collections.Object2ObjectHashMap (sources:
JacksonProcessor annotated with
@com.fasterxml.jackson.databind.annotation.JsonDeserialize >
org.apache.polaris.persistence.nosql.authz.api.ImmutableAclEntry$Json >
org.apache.polaris.persistence.nosql.authz.api.PrivilegeSet >
org.apache.polaris.persistence.nosql.authz.api.Privileges >
org.agrona.collections.Object2ObjectHashMap, JacksonProcessor annotated with
@com.fasterxml.jackson.databind.annotation.JsonDeserialize >
org.apache.polaris.persistence.nosql.authz.api.ImmutableAclEntry$Json >
org.apache.polaris.persistence.nosql.authz.api.PrivilegeSet >
org.apache.polaris.persistence.nosql.authz.api.Privileges >
org.apache.polaris.persistence.nosql.authz.api.Acl$AclBuilder >
org.agrona.collections.Object2ObjectHashMap, JacksonProcessor annotated with
@com.fasterxml.jackson.databind.annotation.JsonDeserialize >
org.apache.polaris.persistence.nosql.coretypes.acl.AclObj >
org.apache.polaris.persistence.nosql.authz.api.Acl > org.
agrona.collections.Object2ObjectHashMap)
Consider adding them to the index either by creating a Jandex index for your
dependency via the Maven plugin, an empty META-INF/beans.xml or
quarkus.index-dependency properties.
```
That said, I'm investigating the reason why this message does not show up
during normal build (no debugger) under #3467.
I believe this resolves this comment thread. @flyrain : WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
