MonkeyCanCode opened a new pull request, #3663: URL: https://github.com/apache/polaris/pull/3663
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> I am not sure if we want to take this PR as it is changing existed integration testing on S3-compatible storage from MinIO to RustFS instead of creating a new test-containers. But here are the high level changes from this PR: 1. Refactored MinIO test-containers to RustFS test-containers 2. Use fixed port for RustFS test-containers due to it needs <domain>:<service_port> when using virtual host style access instead of only domain (details in https://github.com/rustfs/rustfs/issues/1593) 3. Changed S3 exception message as RustFS returns it without period at the end (change in integration-tests/src/main/java/org/apache/polaris/service/it/test/CatalogFederationIntegrationTest.java) 4. Removed custom cmd used by MinIO as RustFS image has those configured already 5. Changed healthcheck port from 9000 (used by MinIO) to 9001 (used by RustFS) ML: https://lists.apache.org/thread/8o31ly7cd8ov70opjbtg630qlhrfl5yh ## Checklist - [x] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [x] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [x] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [x] ๐ก Added comments for complex logic - [x] ๐งพ Updated `CHANGELOG.md` (if needed) - [x] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
