dimas-b commented on code in PR #3663:
URL: https://github.com/apache/polaris/pull/3663#discussion_r2764583191
##########
tools/rustfs-testcontainer/src/main/java/org/apache/polaris/test/rustfs/RustfsContainer.java:
##########
@@ -126,39 +126,39 @@ private static String validateBucketHost(String
bucketName) {
private Optional<String> region;
@SuppressWarnings("unused")
- public MinioContainer() {
+ public RustfsContainer() {
this(null, null, null, null, null);
}
@SuppressWarnings("resource")
- public MinioContainer(
+ public RustfsContainer(
String image, String accessKey, String secretKey, String bucket, String
region) {
super(
- ContainerSpecHelper.containerSpecHelper("minio", MinioContainer.class)
+ ContainerSpecHelper.containerSpecHelper("rustfs",
RustfsContainer.class)
.dockerImageName(image));
- withNetworkAliases(randomString("minio"));
- withLogConsumer(new
Slf4jLogConsumer(LoggerFactory.getLogger(MinioContainer.class)));
- addExposedPort(DEFAULT_PORT);
+ withNetworkAliases(randomString("rustfs"));
+ withLogConsumer(new
Slf4jLogConsumer(LoggerFactory.getLogger(RustfsContainer.class)));
+ addFixedExposedPort(S3_API_PORT, S3_API_PORT);
Review Comment:
Could we have a code comment for this too (for ease of recollection later :)
)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
