MonkeyCanCode commented on code in PR #3663:
URL: https://github.com/apache/polaris/pull/3663#discussion_r2766771877
##########
tools/rustfs-testcontainer/src/main/java/org/apache/polaris/test/rustfs/RustfsContainer.java:
##########
@@ -43,27 +43,27 @@
import software.amazon.awssdk.services.s3.model.CreateBucketRequest;
// CODE_COPIED_TO_POLARIS from Project Nessie 0.104.2
-public final class MinioContainer extends GenericContainer<MinioContainer>
- implements MinioAccess, AutoCloseable {
+public final class RustfsContainer extends GenericContainer<RustfsContainer>
+ implements RustfsAccess, AutoCloseable {
- private static final Logger LOGGER =
LoggerFactory.getLogger(MinioContainer.class);
+ private static final Logger LOGGER =
LoggerFactory.getLogger(RustfsContainer.class);
- private static final int DEFAULT_PORT = 9000;
+ private static final int S3_API_PORT = 9000;
+ private static final int CONSOLE_PORT = 9001;
- private static final String MINIO_ACCESS_KEY = "MINIO_ROOT_USER";
- private static final String MINIO_SECRET_KEY = "MINIO_ROOT_PASSWORD";
- private static final String MINIO_DOMAIN = "MINIO_DOMAIN";
+ private static final String RUSTFS_ACCESS_KEY = "RUSTFS_ACCESS_KEY";
+ private static final String RUSTFS_SECRET_KEY = "RUSTFS_SECRET_KEY";
+ private static final String RUSTFS_SERVER_DOMAINS = "RUSTFS_SERVER_DOMAINS";
Review Comment:
This is because `RUSTFS_SERVER_DOMAIN` is not valid but
`RUSTFS_SERVER_DOMAINS` instead
(https://github.com/rustfs/rustfs/blob/e30781654d26006cda575fa0746775eb3d29b8d3/rustfs/src/config/mod.rs#L73).
But I think you are ref to the variable name. I am changing this to
`RUSTFS_DOMAIN` in the new PR as we are using one domain only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
