SincereXIA commented on pull request #616:
URL: https://github.com/apache/ratis/pull/616#issuecomment-1061667024


   > @SincereXIA , do you think that the first version is better? We should use 
it if it is the case.
   
   @szetszwo , I think this version now is better, In the first version, there 
will always be a thread that repeatedly does meaningless flush. And the 
performance of the previous version is tested without locking. It is not safe. 
After add lock at the `SegmentedRaftLogOutputStream`, the performance of the 
previous version may be not better than the current version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to