Brokenice0415 commented on PR #943: URL: https://github.com/apache/ratis/pull/943#issuecomment-1773133347
@wojiaodoubao, thanks for your case explanation! However, it seems that the new peer 3 is not added to the new configuration by client, meaning the test case only shows a new peer which is not in C_old will shutdown after asking old peers for vote. I tried to add `client.admin().setConfiguration(Arrays.copyOfRange(peers, 0, 4))` before peer 3 starts, and peer 3 does not crash any more. So is after, unless a long sleep, i.e. 1s, before the call of `setConfiguration`. So maybe the shutdown is reasonable. If a new peer starts for a long time but the cluster does not receive the request to change conf, it should shutdown. And in solution 3, the crash may not happen if client sets up a new conf in time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
