adoroszlai commented on code in PR #1371: URL: https://github.com/apache/ratis/pull/1371#discussion_r2906854384
########## ratis-bom/pom.xml: ########## @@ -22,8 +22,21 @@ <packaging>pom</packaging> + <distributionManagement> + <repository> + <id>apache.staging.https</id> + <name>Apache Release Distribution Repository</name> + <url>https://repository.apache.org/service/local/staging/deploy/maven2</url> + </repository> + <snapshotRepository> + <id>apache.snapshots.https</id> + <name>Apache Development Snapshot Repository</name> + <url>https://repository.apache.org/content/repositories/snapshots</url> + </snapshotRepository> + </distributionManagement> + <properties> - <ratis.thirdparty.version>1.0.10</ratis.thirdparty.version> + <ratis.thirdparty.version>1.0.11</ratis.thirdparty.version> Review Comment: Nice catch, I missed following my own comment: https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L185-L186 ########## ratis-bom/pom.xml: ########## @@ -22,8 +22,21 @@ <packaging>pom</packaging> + <distributionManagement> + <repository> + <id>apache.staging.https</id> + <name>Apache Release Distribution Repository</name> + <url>https://repository.apache.org/service/local/staging/deploy/maven2</url> + </repository> + <snapshotRepository> + <id>apache.snapshots.https</id> + <name>Apache Development Snapshot Repository</name> + <url>https://repository.apache.org/content/repositories/snapshots</url> + </snapshotRepository> + </distributionManagement> Review Comment: Should we copy from root POM both `distributionManagement` and the properties it refers to, as is? https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L36-L47 https://github.com/apache/ratis/blob/1433b4cbf7350afcf9b2f871dd48c48e17a91a1d/pom.xml#L171-L176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
