adoroszlai commented on code in PR #1371: URL: https://github.com/apache/ratis/pull/1371#discussion_r2909603360
########## ratis-bom/pom.xml: ########## @@ -22,8 +22,21 @@ <packaging>pom</packaging> + <distributionManagement> + <repository> + <id>apache.staging.https</id> + <name>Apache Release Distribution Repository</name> + <url>https://repository.apache.org/service/local/staging/deploy/maven2</url> + </repository> + <snapshotRepository> + <id>apache.snapshots.https</id> + <name>Apache Development Snapshot Repository</name> + <url>https://repository.apache.org/content/repositories/snapshots</url> + </snapshotRepository> + </distributionManagement> Review Comment: My concern is that if someone builds the project with custom repo (`-DdistMgmtStagingUrl=...` or similar), `ratis-bom` might unexpectedly get deployed to Apache. Copying the properties would prevent it, custom value would be applied to `ratis-bom` lke all other modules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
