spacemonkd commented on code in PR #1538:
URL: https://github.com/apache/ratis/pull/1538#discussion_r3699791500
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -116,6 +136,11 @@ protected void initChannel(SocketChannel ch) {
}
};
+ this.requestExecutor = ConcurrentUtils.newThreadPoolWithMax(
Review Comment:
Yes this was one issue which I missed and faced before (hence the test
failure in flaky test suite).
`corePoolSize=0` + an unbounded queue causes `requestExecutor` to be
single-threaded, and since handle() blocks until commit, this causes the
timeouts.
I have addressed this by switching to a fixed pool for now as the related
change would increase LoC.
Filed https://issues.apache.org/jira/browse/RATIS-2637 for the improvement
as a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
