spacemonkd commented on code in PR #1538:
URL: https://github.com/apache/ratis/pull/1538#discussion_r3700943718
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -155,6 +192,7 @@ public void startImpl() throws IOException {
@Override
public void closeImpl() throws IOException {
+ ConcurrentUtils.shutdownAndWait(requestExecutor);
Review Comment:
Ah, silly mistsake, I missed this. Thanks for pointing it out. Addressed in
the latest comment
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -155,6 +192,7 @@ public void startImpl() throws IOException {
@Override
public void closeImpl() throws IOException {
+ ConcurrentUtils.shutdownAndWait(requestExecutor);
Review Comment:
Ah, silly mistake, I missed this. Thanks for pointing it out. Addressed in
the latest comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
