[
https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244626#comment-16244626
]
Elek, Marton commented on RATIS-129:
------------------------------------
RATIS-132 doesn't fix this problem. See the precommit message of RATIS-132:
https://builds.apache.org/job/PreCommit-RATIS-Build/18/artifact/out/patch-compile-root.txt
It's failed because the <missing> tag couldn't be used together with 'mvn clean
package'. (Profile calculation happens before the 'clean', but the directory is
removed during the clean).
So IMHO this patch could be reverted and the build will be finally fixed. Maybe
[~jingzhao] could confirm, if the problem -- reported in the comment of
RATIS-102 -- no longer exists with RATIS-132 and reverted RATIS-129.
> Compile protobuf and shade if the shaded source directory is missing
> --------------------------------------------------------------------
>
> Key: RATIS-129
> URL: https://issues.apache.org/jira/browse/RATIS-129
> Project: Ratis
> Issue Type: Improvement
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Fix For: 0.2.0-alpha
>
> Attachments: r129_20171103.patch
>
>
> Currently, we uses skipShade to activate protobuf compilation and shading.
> It is better to check if the corresponding shaded source directory is missing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
