[
https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247905#comment-16247905
]
Tsz Wo Nicholas Sze commented on RATIS-129:
-------------------------------------------
That's great. However, it still fails in pre-commit build, e.g.
https://issues.apache.org/jira/browse/RATIS-137?focusedCommentId=16247265&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16247265
It seems that it tried to install or compile only the ratis-server sub-module
so that it failed with or without the patch.
> Compile protobuf and shade if the shaded source directory is missing
> --------------------------------------------------------------------
>
> Key: RATIS-129
> URL: https://issues.apache.org/jira/browse/RATIS-129
> Project: Ratis
> Issue Type: Improvement
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Attachments: r129_20171103.patch
>
>
> Currently, we uses skipShade to activate protobuf compilation and shading.
> It is better to check if the corresponding shaded source directory is missing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
