[ 
https://issues.apache.org/jira/browse/RATIS-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866545#comment-16866545
 ] 

Rajeshbabu Chintaguntla commented on RATIS-541:
-----------------------------------------------

[~elserj] Thanks for review.
bq. This is a snippet from the final state of BulkWrite#run(). When we hit 
batchWritesPresent=true, would will still fall down and write an extra message. 
I think this will inflate the number of records written; I'd expect it to cause 
the BulkReader to also fail (reading more records than it should).
It might be bit confusing may be wrong some cases. Will change it.
bq.It looks like despite a numBatches option, I still have to supply -nr to 
state the total number of rows to be written. Feels to me that -nb should not 
be an option, but automatically figured out by the Tool. WDYT?
Will check it.
bq.Please consolidate these constructors by having the 5-arg constructor call 
the 7-arg constructor.
Will do it.




> Add option to verify correctness of batch and mix of batch and single updates 
> data from LogService in VerficiationTool
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: RATIS-541
>                 URL: https://issues.apache.org/jira/browse/RATIS-541
>             Project: Ratis
>          Issue Type: Improvement
>          Components: LogService
>            Reporter: Rajeshbabu Chintaguntla
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Major
>         Attachments: RATIS-541.patch
>
>
> Currently, in the verification tool, we are verifying single updates 
> correctness in verification but the same can do for batch and mix of batch 
> and single updates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to