[ https://issues.apache.org/jira/browse/RATIS-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16886620#comment-16886620 ]
Hadoop QA commented on RATIS-541: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 8m 33s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 15s{color} | {color:orange} root: The patch generated 4 new + 7 unchanged - 2 fixed = 11 total (was 9) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 44m 30s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 23s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 63m 36s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.examples.filestore.TestFileStoreWithNetty | | | ratis.examples.filestore.TestFileStoreWithGrpc | | | ratis.logservice.TestLogServiceWithGrpc | | | ratis.logservice.TestLogServiceWithNetty | | | ratis.server.simulation.TestRaftStateMachineExceptionWithSimulatedRpc | | | ratis.netty.TestRaftSnapshotWithNetty | | | ratis.server.raftlog.TestRaftLogMetrics | | | ratis.grpc.TestRaftWithGrpc | | | ratis.grpc.TestInstallSnapshotWithGrpc | | | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc | | | ratis.server.simulation.TestServerRestartWithSimulatedRpc | | | ratis.server.simulation.TestRaftSnapshotWithSimulatedRpc | | | ratis.netty.TestRaftStateMachineExceptionWithNetty | | | ratis.server.simulation.TestRaftWithSimulatedRpc | | | ratis.grpc.TestRetryCacheWithGrpc | | | ratis.grpc.TestRaftStateMachineExceptionWithGrpc | \\ \\ || Subsystem || Report/Notes || | Docker | Client=18.09.7 Server=18.09.7 Image:yetus/ratis:date2019-07-17 | | JIRA Issue | RATIS-541 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12974898/RATIS-541.004.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile | | uname | Linux 873e312b6727 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 0d11cd4 | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/PreCommit-RATIS-Build/903/artifact/out/diff-checkstyle-root.txt | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/903/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/903/testReport/ | | Max. process+thread count | 1295 (vs. ulimit of 5000) | | modules | C: ratis-logservice U: ratis-logservice | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/903/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Add option to verify correctness of batch and mix of batch and single updates > data from LogService in VerficiationTool > ---------------------------------------------------------------------------------------------------------------------- > > Key: RATIS-541 > URL: https://issues.apache.org/jira/browse/RATIS-541 > Project: Ratis > Issue Type: Improvement > Components: LogService > Reporter: Rajeshbabu Chintaguntla > Assignee: Rajeshbabu Chintaguntla > Priority: Major > Fix For: 0.4.0 > > Attachments: RATIS-541.003.patch, RATIS-541.004.patch, > RATIS-541.patch, RATIS-541_v2.patch > > > Currently, in the verification tool, we are verifying single updates > correctness in verification but the same can do for batch and mix of batch > and single updates. -- This message was sent by Atlassian JIRA (v7.6.14#76016)