[
https://issues.apache.org/jira/browse/ROCKETMQ-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279784#comment-16279784
]
ASF GitHub Bot commented on ROCKETMQ-323:
-----------------------------------------
zhouxinyu opened a new pull request #200: [ROCKETMQ-323] Release semaphore
after callback being finished for async invoke
URL: https://github.com/apache/rocketmq/pull/200
## What is the purpose of the change
Currently, the async semaphore will be released before invoking the
callback, if the callback is a heavy task which is not recommended, lots of
async requests will be queued in `publicExecutor` thread pool, may cause OOM or
FGC.
## Brief changelog
Adjust the release order between callback and response future, release
semaphore after callback being finished for async invoke.
## Verifying this change
Run the provided unit tests.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ROCKETMQ-XXX] Fix
UnknownException when host config not exist`. Each commit in the pull request
should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a
little better when cross module dependency exist. If the new feature or
significant change is committed, please remember to add integration-test in
[test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [x] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Release semaphore after callback being finished for async invoke
> ----------------------------------------------------------------
>
> Key: ROCKETMQ-323
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-323
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: yukon
> Assignee: yukon
> Fix For: 4.2.0
>
>
> Currently, the async semaphore will be released before invoking the callback,
> if the callback is a heavy task which is not recommended, lots of async
> requests will be queued in `publicExecutor` thread pool, may cause OOM or FGC.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
